[sql-19] sessions: last misc prep commits #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only really ever use it in one place and even then, only for a session State that we no longer use anymore. This is done to make the SQL queries we will need to implement the SQL Store more simple.
Before we add the SQL implementation of the store, we fix this timestamp to be a more realistic number. This is needed since in sqlite, timestamps are serialised as strings and golang actually cant parse the string for the current timestamp back into a time.Time. This is the error that will be encountered: `parsing time "99999-01-01 00:00:00 +0000 UTC" as "2006-01-02 15:04:05.999999999 -0700 MST": cannot parse "9-01-01 00:00:00 +0000 UTC" as "-"`
This will make it possible in SQL unit tests to extract the BaseDB used for accounts and use it to init another Store backed by the same BaseDB.
ellemouton
added
sql-ize
no-changelog
ellemouton
requested review from
ViktorT-11 and
bitromortac
and removed request for
ViktorT-11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last PR for preparing the sessions Store to be ready for a SQL implementation.
3 unrelated tiny commits - see commit messages for details :)